Remove the obsolete blind-writes config option
authorMichael McMaster <michael@codesrc.com>
Thu, 27 May 2021 22:48:21 +0000 (08:48 +1000)
committerMichael McMaster <michael@codesrc.com>
Thu, 27 May 2021 22:48:21 +0000 (08:48 +1000)
CHANGELOG
include/scsi2sd.h
src/scsi2sd-util6/BoardPanel.cc

index 0783ca317cd47502400a0eb42aaeb7f67355ded2..f37416a3abfb1df276b41c97a0ecd25ca0e63b34 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,7 @@
+20210628        6.4.11
+    - Remove the "Blind Writes" option from scsi2sd-util. The firmware no longer
+    requires this option for improved write performance
+
 20210508        6.4.4
     - More bug fixes for firmware hanging during read/writes
 
index 1176a02cfb69c26af717a48ec1efa4432e2a20de..9a988bf07e9e87a62fba7b2b074b448c9ef609f7 100755 (executable)
@@ -62,8 +62,8 @@ typedef enum
 
 typedef enum
 {
-       S2S_CFG_ENABLE_TERMINATOR = 1,
-       S2S_CFG_ENABLE_BLIND_WRITES = 2,
+       S2S_CFG_ENABLE_TERMINATOR = 1
+       //S2S_CFG_ENABLE_BLIND_WRITES = 2, // Obosolete
 } S2S_CFG_FLAGS6;
 
 typedef enum
index c342cb20fdaf893fc6b322dfd6aea6e8bdfe2b22..e7a3b1901700a18390843865c5266c3ac012506d 100644 (file)
@@ -158,16 +158,6 @@ BoardPanel::BoardPanel(wxWindow* parent, const S2S_BoardCfg& initialConfig) :
        myMapLunsCtrl->SetToolTip(_("Treat LUNS as IDs instead. Supports multiple drives on XEBEC S1410 SASI Bridge"));
        fgs->Add(myMapLunsCtrl);
 
-
-       fgs->Add(new wxStaticText(this, wxID_ANY, wxT("")));
-       myBlindWriteCtrl =
-               new wxCheckBox(
-                       this,
-                       ID_blindWriteCtrl,
-                       _("Enable Blind Writes"));
-       myBlindWriteCtrl->SetToolTip(_("Enable writing to the SD card before all the SCSI data has been received."));
-       fgs->Add(myBlindWriteCtrl);
-
        wxBoxSizer* hbox = new wxBoxSizer(wxHORIZONTAL);
        hbox->Add(fgs, 1, wxALL | wxEXPAND, 15);
        this->SetSizer(hbox);
@@ -193,8 +183,7 @@ BoardPanel::getConfig() const
                (mySelLatchCtrl->IsChecked() ? S2S_CFG_ENABLE_SEL_LATCH : 0) |
                (myMapLunsCtrl->IsChecked() ? S2S_CFG_MAP_LUNS_TO_IDS : 0);
 
-       config.flags6 = (myTermCtrl->IsChecked() ? S2S_CFG_ENABLE_TERMINATOR : 0) |
-               (myBlindWriteCtrl->IsChecked() ? S2S_CFG_ENABLE_BLIND_WRITES : 0);
+       config.flags6 = (myTermCtrl->IsChecked() ? S2S_CFG_ENABLE_TERMINATOR : 0);
 
        config.startupDelay = CtrlGetValue<unsigned int>(myStartDelayCtrl).first;
        config.selectionDelay = CtrlGetValue<unsigned int>(mySelDelayCtrl).first;
@@ -211,7 +200,6 @@ BoardPanel::setConfig(const S2S_BoardCfg& config)
        myUnitAttCtrl->SetValue(config.flags & S2S_CFG_ENABLE_UNIT_ATTENTION);
        myScsi2Ctrl->SetValue(config.flags & S2S_CFG_ENABLE_SCSI2);
        myTermCtrl->SetValue(config.flags6 & S2S_CFG_ENABLE_TERMINATOR);
-       myBlindWriteCtrl->SetValue(config.flags6 & S2S_CFG_ENABLE_BLIND_WRITES);
        mySelLatchCtrl->SetValue(config.flags & S2S_CFG_ENABLE_SEL_LATCH);
        myMapLunsCtrl->SetValue(config.flags & S2S_CFG_MAP_LUNS_TO_IDS);